Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for additional polars data types #244

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

brianheineman
Copy link
Contributor

@brianheineman brianheineman commented Dec 18, 2024

Improve Polars Value support for #240

@github-actions github-actions bot added the enhancement New feature or request label Dec 18, 2024
Copy link

🐰 Bencher Report

Branchsupport-additional-polars-types
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
postgres-embedded📈 view plot
⚠️ NO THRESHOLD
835,990,000.00
postgresql-embedded📈 view plot
⚠️ NO THRESHOLD
853,490,000.00
rusqlite📈 view plot
⚠️ NO THRESHOLD
4,661,400.00
sqlite📈 view plot
⚠️ NO THRESHOLD
4,987,300.00
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 12 lines in your changes missing coverage. Please review.

Project coverage is 93.64%. Comparing base (9a24862) to head (0c7d40c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rsql_drivers/src/polars/value.rs 93.06% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   93.56%   93.64%   +0.08%     
==========================================
  Files         107      108       +1     
  Lines       13275    13433     +158     
==========================================
+ Hits        12421    12580     +159     
+ Misses        854      853       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit 88742b8 into main Dec 18, 2024
25 of 26 checks passed
@brianheineman brianheineman deleted the support-additional-polars-types branch December 18, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant