Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add xml driver #249

Merged
merged 1 commit into from
Jan 6, 2025
Merged

feat: add xml driver #249

merged 1 commit into from
Jan 6, 2025

Conversation

brianheineman
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

🐰 Bencher Report

Branchadd-xml-driver
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencymilliseconds (ms)
postgres-embedded📈 view plot
⚠️ NO THRESHOLD
822.79
postgresql-embedded📈 view plot
⚠️ NO THRESHOLD
843.56
rusqlite📈 view plot
⚠️ NO THRESHOLD
4.57
sqlite📈 view plot
⚠️ NO THRESHOLD
4.99
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 93.65672% with 17 lines in your changes missing coverage. Please review.

Project coverage is 93.63%. Comparing base (5a24836) to head (074ac07).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rsql_drivers/src/xml/driver.rs 92.57% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   93.64%   93.63%   -0.01%     
==========================================
  Files         109      110       +1     
  Lines       13546    13799     +253     
==========================================
+ Hits        12685    12921     +236     
- Misses        861      878      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit 610048e into main Jan 6, 2025
24 checks passed
@brianheineman brianheineman deleted the add-xml-driver branch January 6, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant