Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add excel and ods drivers #253

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

brianheineman
Copy link
Contributor

@brianheineman brianheineman commented Jan 8, 2025

Addresses #217

@github-actions github-actions bot added the enhancement New feature or request label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

🐰 Bencher Report

Branchadd-excel-and-ods-drivers
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencymilliseconds (ms)
postgres-embedded📈 view plot
⚠️ NO THRESHOLD
828.25
postgresql-embedded📈 view plot
⚠️ NO THRESHOLD
836.62
rusqlite📈 view plot
⚠️ NO THRESHOLD
4.36
sqlite📈 view plot
⚠️ NO THRESHOLD
4.68
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 85.25346% with 32 lines in your changes missing coverage. Please review.

Project coverage is 93.50%. Comparing base (de16b76) to head (44eef13).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
rsql_drivers/src/excel/driver.rs 79.08% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   93.63%   93.50%   -0.14%     
==========================================
  Files         111      113       +2     
  Lines       13918    14132     +214     
==========================================
+ Hits        13032    13214     +182     
- Misses        886      918      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit 01103e0 into main Jan 8, 2025
25 of 26 checks passed
@brianheineman brianheineman deleted the add-excel-and-ods-drivers branch January 8, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant