Skip to content
This repository has been archived by the owner on Oct 20, 2024. It is now read-only.

fix: darwin builds and shell aliases #5

Closed
wants to merge 1 commit into from

Conversation

storopoli
Copy link

@storopoli storopoli commented Apr 18, 2024

  • Fixes darwin builds by disabling bitcoind tests and checks (just compile please)
  • Makes the aliases robust to use the bin/ directory from the pkg itself

Cc @plebhash who was also experiencing issues.

- Fixes darwin builds by disabling `bitcoind` tests and checks (just compile please)
- Makes the aliases robust to use the `bin/` directory from the pkg itself
@plebhash
Copy link

plebhash commented Apr 18, 2024

I tested and the errors coming from bitcoind cleared up on darwin.

But for some reason, the resulting lightningd binary does not have a --bitcoin-datadir CLI option on a darwin build:

lightningd: --bitcoin-datadir=/tmp/cashu-rs-mint/bitcoin: unknown option

This does not happen on linux.

edit: this seems to be an issue with the clightning derivation on darwin.
reported here NixOS/nixpkgs#305060

@thesimplekid
Copy link
Owner

Thanks for this. I am not currently testing on darwin but I should. I'm happy to merge the changes as they're working for me on nixos but haven't run them on darwin. Looking at @plebhash's comment it looks like it fixes one issue but creates another so still doesn't work on darwin?

@storopoli
Copy link
Author

Yes it is an issue reported upstream to NixOS/nixpkgs. We should wait for updates there.

@storopoli
Copy link
Author

This is ready to merge now, ping @thesimplekid.

@plebhash
Copy link

plebhash commented May 23, 2024

This is ready to merge now, ping @thesimplekid.

was there any progress on the clightning derivation for darwin?
I don't see any updates from the issues I created.

@storopoli
Copy link
Author

Ok I saw wrong issues, thanks for linking the right ones :)

@storopoli storopoli closed this Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants