Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert pipeline management restructure #5328

Conversation

ujfalusi
Copy link
Collaborator

Looks like the #5262 caused more failures than just in IPC3.
suspend with capture in IPC4 looks like to be affected and DSPless mode also got regressed around the same time.

Let's see if a revert of the changes can fix this and if it does, I think we should proceed with it unless the issues can be addressed.

@ujfalusi ujfalusi changed the title Peter/sof/pr/revert pipeline restructure 01 Revert pipeline management restructure Feb 13, 2025
@ujfalusi
Copy link
Collaborator Author

SOFCI TEST

@ujfalusi ujfalusi marked this pull request as ready for review February 13, 2025 12:52
@ujfalusi
Copy link
Collaborator Author

@ranj063, taking this out from draft. The CI results confirm the worst that the original series introduced not trivial regressions even with IPC4. CI runs with this PR:
LNL: 49699
TGL/MTL: 49700
IPC3: 49701

Something goes wrong for sure and my fixup, while helping with IPC3, it still leaves IPC4 failing.

Copy link
Collaborator

@lyakh lyakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes the regression - tested on LNL nocodec

@lgirdwood
Copy link
Member

@ujfalusi @ranj063 can we incrementally test/merge this series after revert is merged - its likely just one patch that has the impact. Will help us understand the breakage. Thanks !

@ranj063 ranj063 merged commit 3a7fbd9 into thesofproject:topic/sof-dev Feb 13, 2025
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants