Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-kmod-load-unload-after-playback.sh: fix source reference and quote issues. #1042

Merged
merged 2 commits into from
Jun 5, 2023
Merged

check-kmod-load-unload-after-playback.sh: fix source reference and quote issues. #1042

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
945d5cf
check-kmod-load-unload-after-playback.sh: fix source reference and qu…
greg-intel May 25, 2023
1e1ad96
Changed comparator to better handle edge case.
greg-intel May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions test-case/check-kmod-load-unload-after-playback.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,11 @@ set -e
## check kernel log and find no errors
##

source $(dirname ${BASH_SOURCE[0]})/../case-lib/lib.sh
# shellcheck source=case-lib/lib.sh
source "$(dirname "${BASH_SOURCE[0]}")"/../case-lib/lib.sh
case_dir=$(cd "$(dirname "${BASH_SOURCE[0]}")"; pwd)

OPT_NAME['t']='tplg' OPT_DESC['t']='tplg file, default value is env TPLG: $TPLG'
OPT_NAME['t']='tplg' OPT_DESC['t']="tplg file, default value is env TPLG: $TPLG"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a useful bug fix!

OPT_HAS_ARG['t']=1 OPT_VAL['t']="$TPLG"

OPT_NAME['l']='loop'
Expand Down Expand Up @@ -85,7 +86,7 @@ do
dlogi "platform doesn't support runtime pm, skip waiting" && break
[[ $(sof-dump-status.py --dsp_status 0) == "suspended" ]] && break
sleep 1
if [ $i -eq 15 ]; then
if [ "$i" -ge 15 ]; then
die "dsp is not suspended after 15s, end test"
fi
done
Expand Down