Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] dai-zephyr: use frames aligned for multi-endpoint copy #9196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iganakov
Copy link
Contributor

@iganakov iganakov commented Jun 5, 2024

When aggregating streams using dai_zephyr_multi_endpoint_copy() multiple glitches observed in audio streams with odd number of channels. Use audio_stream_avail_frames_aligned() for every dai in a loop to correctly calculate processing frames.

src/audio/dai-zephyr.c Outdated Show resolved Hide resolved
@iganakov iganakov force-pushed the iganakov/multi_endpoint_copy_fix branch from fc9ad55 to 6bdc7d4 Compare June 7, 2024 09:09
src/audio/dai-zephyr.c Outdated Show resolved Hide resolved
@iganakov iganakov force-pushed the iganakov/multi_endpoint_copy_fix branch 2 times, most recently from 2f8bcfd to 26e362a Compare June 11, 2024 10:32
src/audio/dai-zephyr.c Outdated Show resolved Hide resolved
@iganakov iganakov force-pushed the iganakov/multi_endpoint_copy_fix branch from 26e362a to 31bf254 Compare June 19, 2024 14:17
@iganakov iganakov force-pushed the iganakov/multi_endpoint_copy_fix branch from 31bf254 to 04cc408 Compare June 19, 2024 14:29
When aggregating streams using dai_zephyr_multi_endpoint_copy()
multiple glitches observed in audio streams with odd number of channels.
Use audio_stream_avail_frames_aligned() for every dai in a loop
to correctly calculate processing frames.

Signed-off-by: Ievgen Ganakov <[email protected]>
@iganakov iganakov force-pushed the iganakov/multi_endpoint_copy_fix branch from 04cc408 to 25fbae0 Compare June 19, 2024 15:57
@kv2019i
Copy link
Collaborator

kv2019i commented Jun 20, 2024

This doesn't look good in the CI results https://sof-ci.01.org/sofpr/PR9196/build5811/devicetest/index.html?model=LNLM_SDW_AIOC&testcase=check-playback-10sec I don't think we have this in baseline.

@lgirdwood
Copy link
Member

This doesn't look good in the CI results https://sof-ci.01.org/sofpr/PR9196/build5811/devicetest/index.html?model=LNLM_SDW_AIOC&testcase=check-playback-10sec I don't think we have this in baseline.

@iganakov I dont think any of the CI tests are doing odd number of channels wrt the number of test failures, this looks like we have impact on even channel numbers too.

@lgirdwood lgirdwood added this to the v2.11 milestone Jun 25, 2024
@iganakov
Copy link
Contributor Author

@kv2019i @lgirdwood I'm able to reproduce the issue with Windows driver also. Looks like something has changed in FW since I implemented this fix some time ago. Let me find the root cause.

Copy link
Contributor

@dnikodem dnikodem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As CI is failing please do not merge this PR.

@iganakov iganakov changed the title dai-zephyr: use frames aligned for multi-endpoint copy [DNM] dai-zephyr: use frames aligned for multi-endpoint copy Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants