-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] dai-zephyr: use frames aligned for multi-endpoint copy #9196
base: main
Are you sure you want to change the base?
[DNM] dai-zephyr: use frames aligned for multi-endpoint copy #9196
Conversation
fc9ad55
to
6bdc7d4
Compare
2f8bcfd
to
26e362a
Compare
26e362a
to
31bf254
Compare
31bf254
to
04cc408
Compare
When aggregating streams using dai_zephyr_multi_endpoint_copy() multiple glitches observed in audio streams with odd number of channels. Use audio_stream_avail_frames_aligned() for every dai in a loop to correctly calculate processing frames. Signed-off-by: Ievgen Ganakov <[email protected]>
04cc408
to
25fbae0
Compare
This doesn't look good in the CI results https://sof-ci.01.org/sofpr/PR9196/build5811/devicetest/index.html?model=LNLM_SDW_AIOC&testcase=check-playback-10sec I don't think we have this in baseline. |
@iganakov I dont think any of the CI tests are doing odd number of channels wrt the number of test failures, this looks like we have impact on even channel numbers too. |
@kv2019i @lgirdwood I'm able to reproduce the issue with Windows driver also. Looks like something has changed in FW since I implemented this fix some time ago. Let me find the root cause. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As CI is failing please do not merge this PR.
Release reminder - one week to v2.11-rc1. |
frames_aligned = | ||
audio_stream_avail_frames_aligned(&dd[i]->dma_buffer->stream, | ||
&multi_endpoint_buffer->stream); | ||
frames = MIN(frames, frames_aligned); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't stat
be used? If not - do we still need dma_get_status()
?
When aggregating streams using
dai_zephyr_multi_endpoint_copy()
multiple glitches observed in audio streams with odd number of channels. Useaudio_stream_avail_frames_aligned()
for every dai in a loop to correctly calculate processing frames.