[SKIP CI] .github/zephyr: simplify and fix the git describe performance hack #9801
+109
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
marc-hb
force-pushed
the
simplify-git-describe
branch
2 times, most recently
from
d087842 to
a8cb0ad
Compare
|
Linux and windows identical again in https://github.com/thesofproject/sof/actions/runs/13018380889/job/36313882198?pr=9801 |
marc-hb
force-pushed
the
simplify-git-describe
branch
2 times, most recently
from
8a9c895 to
685c087
Compare
Fixes the git describe/tag performance hack added in commit 2328478 (".github/zephyr.yml: fix tags missing from `git -C zephyr/ describe`") which worked for an amazingly long time (1.5 year) but apparently ran its course. Git version 2.48 apparently does not like it anymore. Replace it with something slower but simpler and safer. Should fix build reproducibility issue thesofproject#9797, much more details there. Also fixes commit 4bc6488 (".github/zephyr: de-hardcode the name of the zephyr remote") Signed-off-by: Marc Herbert <[email protected]>
marc-hb
force-pushed
the
simplify-git-describe
branch
2 times, most recently
from
429c30d to
ff3f6d2
Compare
This matters because the build reproducibility test is based on the list of Windows builds. Also: - Bump -d(ebug) build to something newer: LNL - Group MTL and LNL to save one line Signed-off-by: Marc Herbert <[email protected]>
More progress towards trimming down pull-request.yml Important benefit and "secret" agenda: remove the constantly failing sof-docs from daily builds, which will make them green again. Green daily builds are important to quickly spot regressions like for instance thesofproject#9797 Signed-off-by: Marc Herbert <[email protected]>
marc-hb
force-pushed
the
simplify-git-describe
branch
from
ff3f6d2 to
5e51eb3
Compare
Merged
kv2019i
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the git describe/tag performance hack added in commit 2328478 (".github/zephyr.yml: fix tags missing from
git -C zephyr/ describe") which worked for an amazingly long time (1.5 year) but apparently ran its course. Git version 2.48 apparently does not like it anymore. Replace it with something slower but simpler and safer.Should fix build reproducibility issue #9797, much more details there.
Also fixes commit 4bc6488 (".github/zephyr: de-hardcode the name of the zephyr remote")