repo: Do not use naive datetimes with tuf API #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The datetime format is not really part of TUF API but we meddle in in the client internals to do the "valid X days from now" test... so need to match the used datetime format.
|
e2e tests could probably cover this... but I'd like to get this fix released soon: I'm marking this draft so I can include the version bump right here. |
|
Looks good. Do you know what was the breaking change that introduced this? |
kommendorkapten
approved these changes
Jan 15, 2025
Yes: the python-tuf public API did not change in the upgrade I did but tuf-on-ci-test-client script (used in test-repository actions) tweaks one thing python-tuf client internals... that one thing is expiry which now needs to be in UTC not "naive" datetime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The datetime format is not really part of TUF API but we meddle in in the client internals to do the "valid X days from now" test... so need to match the used datetime format.
Fixes #512
I've tested this in jku/tuf-demo#122: seems to work ok -- I'll also modify tuf-demo so that we see it work after merge