Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil pointer dereference within refresh error path #179

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Fix nil pointer dereference within refresh error path #179

merged 1 commit into from
Jul 8, 2024

Conversation

PaarthShah
Copy link
Contributor

@PaarthShah PaarthShah commented Jul 6, 2024 •
edited
Loading

Fixes #178

Since readUsageInformation can return nil for lui, performing this log statement before doing the err check is unsafe

@PaarthShah PaarthShah mentioned this pull request Jul 6, 2024
Closed
@theurichde theurichde merged commit c916911 into theurichde:main Jul 8, 2024
3 checks passed
@PaarthShah PaarthShah deleted the fix-nullptr-deference branch July 8, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theurichde theurichde theurichde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] go-aws-sso refresh raises panic: runtime error: invalid memory address or nil pointer dereference
2 participants
@PaarthShah @theurichde