Update Terraform Syntax and Ruby Function Version #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix #10 and thewca/worldcubeassociation.org#8235 |
|
@lgarron are you reviewing this or should I get someone else? |
lgarron
reviewed
Aug 30, 2023
| @@ -21,8 +16,8 @@ resource "aws_s3_bucket" "terraform-state-storage-s3" { | |||
| resource "aws_dynamodb_table" "dynamodb-terraform-state-lock" { | |||
| name = "wca-terraform-state-lock-dynamo" | |||
| hash_key = "LockID" | |||
| read_capacity = 20 | |||
| write_capacity = 20 | |||
| read_capacity = 5 | |||
There was a problem hiding this comment.
this dynamodb table is just there so two people don't update the terraform template at once (I honestly think it's quite unnecessary anyway). But it can't lead to downtime for wca.link has it's unrelated
Is there anyone more qualified to review? I don't know Terraform, but I don't see any obvious issues with the changes. (Also, all this configuration makes me miss Google App Engine. Or at least some sort of edge workers.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
terraform plan)