Move Registration Error Messages to React #10411
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FinnIckler
force-pushed
the
v3/registrationWarnings
branch
from
91b2a5d to
65573a3
Compare
gregorbg
reviewed
Jan 4, 2025
| @@ -267,11 +267,12 @@ | |||
| <% end %> | |||
| <% end %> | |||
|
|
|||
| <% @competition.warnings_for(current_user).each do |field, message| %> | |||
| <%= alert :warning, message, note: true %> | |||
| <% unless defined?(@skip_warnings )%> | |||
There was a problem hiding this comment.
Why are you wrapping this in a defined? call? The variable @skip_warnings itself is a boolean, so unless @skip_warnings should do.
There was a problem hiding this comment.
I think that caused the tests to fail? unless @skip_warnings was my original try, let me try again
There was a problem hiding this comment.
Interestingly you can't do that because @undefined_variable == false -> false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I choose to do multiple ifs because it was getting complicated.
Also: is it time to only render the registration requirements in the Panel, or do we want to continue having them on top?