Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cleanly transition to mandatory :payment_integration parameter in URL #10477

Merged

Conversation

gregorbg
Copy link
Member

Basically a copy-cat of #10458, except that the parameter in the URL is not marked as required yet.

This will make it so that if anybody starts a Stripe session with the old (paremeter-less, because optional) URL during deployment, the route would still resolve after coming back to the newly deployed server.

Highly unlikely circumstance anyways (somebody would need to perform their 3DS authorization exactly during the time window that AWS swaps out our ECS instances and switches over the traffic) but with payments you can never be safe enough.

Since the original #10458 is already reviewed and approved, I will merge this as soon as tests pass.

@gregorbg
Copy link
Member Author

Merging based on the review of #10458

This PR literally cherry-picks the exact same commits (and squashes them, so the hashes won't match. But the diff does!)

@gregorbg gregorbg merged commit 1dc28f5 into thewca:main Dec 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant