Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @cubing/icons to v3.0.0 #10526

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Bump @cubing/icons to v3.0.0 #10526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5623696
Bump `@cubing/icons` to v2.1.0-pre.3
lgarron Jan 4, 2025
77de4d1
grrr
lgarron Jan 4, 2025
c841a6c
hmm
lgarron Jan 4, 2025
ec937f5
Bump `@cubing/icons` to v3.0.0
lgarron Jan 9, 2025
9a46c68
Try to fix the paths.
lgarron Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/assets/stylesheets/pdf.css.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ a {

// We need the import here, otherwise Rails' asset adds a BOM at the beginning of it,
// and the font doesn't get recognize!
// This refers to: `[repo root]/node_modules/@cubing/icons/dist/lib/@cubing/icons/cubing-icons.css`,
// per a configuration in `assets.rb`.
@import "cubing-icons"; /* stylelint-disable-line no-invalid-position-at-import-rule */

header {
Expand Down
7 changes: 6 additions & 1 deletion config/initializers/assets.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@
# helper!
# wicked_pdf's helpers can't handle "packs_with_chunks" and therefore cannot
# properly inline our packs :(
Rails.application.config.assets.paths << Rails.root.join("node_modules", "@cubing", "icons", "www", "css")
# Note: reaching into the package structure violates the semantics of package
# exports, which could theoretically turn any release of `@cubing/icons` into a
# breaking one. However, this path should be fairly stable, and the usage here
# should be safe as long as `@cubing/icons` is not bumped automatically without
# exercising this code path in a test.
Rails.application.config.assets.paths << Rails.root.join("node_modules", "@cubing", "icons", "dist", "lib", "@cubing", "icons")

# Precompile additional assets.
# application.js, application.css, and all non-JS/CSS in app/assets folder are already added.
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"@babel/preset-env": "^7.26.0",
"@babel/preset-react": "^7.26.3",
"@babel/runtime": "^7.26.0",
"@cubing/icons": "^1.1.3",
"@cubing/icons": "^3.0.0",
"@fullcalendar/core": "^6.1.15",
"@fullcalendar/interaction": "^6.1.15",
"@fullcalendar/luxon3": "^6.1.15",
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1898,10 +1898,10 @@ __metadata:
languageName: node
linkType: hard

"@cubing/icons@npm:^1.1.3":
version: 1.1.3
resolution: "@cubing/icons@npm:1.1.3"
checksum: 10c0/332fb3a4888020c39031201e9045569a190e9b40852c1857cdc44e624a9bf09d4fafc72691c8596ba7c59411ffc9dd79bb6686f48608f7438807ed099a22c805
"@cubing/icons@npm:^3.0.0":
version: 3.0.0
resolution: "@cubing/icons@npm:3.0.0"
checksum: 10c0/7ac6721ba9a8b206ea8171697d1485b4c36f8ad3c4564f852f42cfd7de6ed102d35af0982ad8c6b9b3b16b46d1ee770274375a5ed4ae976cd1fd361198f1896b
languageName: node
linkType: hard

Expand Down Expand Up @@ -10159,7 +10159,7 @@ __metadata:
"@babel/preset-env": "npm:^7.26.0"
"@babel/preset-react": "npm:^7.26.3"
"@babel/runtime": "npm:^7.26.0"
"@cubing/icons": "npm:^1.1.3"
"@cubing/icons": "npm:^3.0.0"
"@fullcalendar/core": "npm:^6.1.15"
"@fullcalendar/interaction": "npm:^6.1.15"
"@fullcalendar/luxon3": "npm:^6.1.15"
Expand Down
Loading