docker-opengl centos branch rebased #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use makefile
This useful image have been created to be used for Slicer CI. Because the slicer build tree docker image (slicer/slicer-build) is based on centos 5, then we have to run the test on centos 5 if we don't want to rebuild everything and just share the volume which contains the build tree.
This was referenced Oct 24, 2016
ENH: Newer version of Dockerfile required for CircleCI to support 'ARG'
MayeulChassagnard
force-pushed
the
centos-2016.10.20-rebased
branch
from
3e944c7
to
22d9564
Compare
|
I am merging |
|
I have updated the |
|
Perhaps it would have been better to just set the centos branch on the same commit history as the master branch because there is lot of conflicts.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't automatically merge because the centos branch needs to be update with the master branch modifications (Makefile, etc.)
CC: @thewtex @jcfr