make optional auth block of httpd-nagios.conf

[vchepkov]

apache_httpd_htpasswd_source is optional in server.pp, this change makes block depending
on it optional as well

[thias]

Nice corner case! I'm managing the file from elsewhere in my puppet manifests. So I actually need the httpd configuration for the /etc/nagios/.htpasswd file present, while having apache_httpd_htpasswd_source set to false. So your change would break my nagios servers :-)

Maybe add an $apache_httpd_htpasswd parameter defaulting to true to control that template part?

If that would work for you, or if you can think of any better way to fulfill your requirements as well as mine, please update this PR, and also make sure not to remove the last empty line of the file for nothing (as it changes for everyone and triggers a useless service reload).

[vchepkov]

oh, intersting, I can see how it can be useful, if the same file shared between different modules.
How about we introduce two variables instead?

apache_httpd_htpasswd_path = '/etc/nagios/.htpasswd'
apache_httpd_htpasswd_manage = false

First one would determine location of the file, since some people would have it in /etc/httpd/conf/, for example. And by setting it to undef, one can disable auth block

second one will determine if we want to manage this file by this module.

[vchepkov]

P.S. My editor removes 'wasteful' spaces

[vchepkov]

Haven't heard from you, so I will redo the change the way I suggested