Fix off-by-one line number in compact output #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mikaraunio, thank you for taking a look at this. I’m surprised this change would be appropriate – last time I troubleshooted this the compact output was the only one that was correct IIRC. |
|
Hi @thibaudcolas. The compact output would be the correct one if line numbers were always 0-indexed before the |
|
Closing as per discussion in #22. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line numbers in compact output are higher by one compared to json and stylish outputs. This fixes that.
The
+ 1looks intentional so was worried this change could break something else. HoweverIssueLocation.__str__()is only called fromIssue.__str__()which is only used informat_compact()so this should be safe.Lint and tests pass.