Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Adapt the split and cross strategies to quantile regression class #5

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

thibaultcordier
Copy link
Owner

@thibaultcordier thibaultcordier commented Mar 9, 2023

Description

At the moment, conformalized quantile regression has only been implemented with the split-conformal strategy. It would be worth extending it to cross-CQR with the cv argument. This PR proposes to adapt the quantile regression class for split and cross conformal strategies by adding to the init method the cv parameter so that it is comparable to the regression class.

Fixes #4

Type of change

Please remove options that are irrelevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Uniformisation of regression tests (for cross settings).
  • Adaptation of quantile regression tests to changes.

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Adapt the split and cross strategies to quantile regression class
1 participant