Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aggregation if the same class name exists in two different namespaces #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bansan85
Copy link

@bansan85 bansan85 commented May 7, 2024

Aggregation is randomly wrong if the same class name exists in two different namespaces.

@bansan85 bansan85 force-pushed the same_class_not_namespace branch 2 times, most recently from 7fd42f8 to 4425ce3 Compare May 13, 2024 13:34
@thibaultmarin
Copy link
Owner

Thanks for the pull request. This reveals a more widespread bug that affects all class relationships. v0.8.5 attempts to fix it, could you please give it a try and post an example if you still observe issues? Thanks

@bansan85
Copy link
Author

Thanks for the fix. I will test it in few days.

By the way, I also sent fixes in robotpy/CppHeaderParser. I will be great if you could update to the latest commit.

@bansan85
Copy link
Author

It's really better but I still have one problem.

If I run "hpp2plantuml.py -i urx/*.h -o architecture.puml"

urx.zip

I randomly have:

/' Aggregation relationships '/

urx.detail.Acquisition "2" *-- urx.detail.Group


urx.detail.GroupData *-- urx.detail.Group

or

/' Aggregation relationships '/

urx.detail.Acquisition *-- urx.detail.Group


urx.detail.Acquisition *-- urx.detail.GroupData


urx.detail.GroupData *-- urx.detail.Group

@thibaultmarin
Copy link
Owner

v0.8.6 should improve the results on your tests (although it does not provide a reliable solution for this type of issues). Please let me know if you encounter more issues. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants