generated from python-discord/code-jam-template
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
0 parents
commit a69e5e2
Showing
9 changed files
with
363 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
# GitHub Action Workflow enforcing our code style. | ||
|
||
name: Lint | ||
|
||
# Trigger the workflow on both push (to the main repository, on the main branch) | ||
# and pull requests (against the main repository, but from any repo, from any branch). | ||
on: | ||
push: | ||
branches: | ||
- main | ||
pull_request: | ||
# Brand new concurrency setting! This ensures that not more than one run can be triggered for the same commit. | ||
# It is useful for pull requests coming from the main repository since both triggers will match. | ||
concurrency: lint-${{ github.sha }} | ||
|
||
jobs: | ||
lint: | ||
runs-on: ubuntu-latest | ||
|
||
env: | ||
# The Python version your project uses. Feel free to change this if required. | ||
PYTHON_VERSION: "3.10" | ||
|
||
steps: | ||
# Checks out the repository in the current folder. | ||
- name: Checks out repository | ||
uses: actions/checkout@v3 | ||
|
||
# Set up the right version of Python | ||
- name: Set up Python ${{ env.PYTHON_VERSION }} | ||
uses: actions/setup-python@v3 | ||
with: | ||
python-version: ${{ env.PYTHON_VERSION }} | ||
|
||
- name: Run pre-commit hooks | ||
uses: pre-commit/[email protected] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# Files generated by the interpreter | ||
__pycache__/ | ||
*.py[cod] | ||
|
||
# Environment specific | ||
.venv | ||
venv | ||
.env | ||
env | ||
|
||
# Unittest reports | ||
.coverage* | ||
|
||
# Logs | ||
*.log | ||
|
||
# PyEnv version selector | ||
.python-version | ||
|
||
# Built objects | ||
*.so | ||
dist/ | ||
build/ | ||
|
||
# IDEs | ||
# PyCharm | ||
.idea/ | ||
# VSCode | ||
.vscode/ | ||
# MacOS | ||
.DS_Store |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
## Pre-commit setup | ||
# See https://github.com/python-discord/code-jam-template/tree/main#pre-commit-run-linting-before-committing | ||
|
||
# Make sure to edit the `additional_dependencies` list if you want to add plugins | ||
|
||
repos: | ||
- repo: https://github.com/pre-commit/pre-commit-hooks | ||
rev: v2.5.0 | ||
hooks: | ||
- id: check-toml | ||
- id: check-yaml | ||
- id: end-of-file-fixer | ||
- id: trailing-whitespace | ||
args: [--markdown-linebreak-ext=md] | ||
|
||
- repo: https://github.com/pre-commit/pygrep-hooks | ||
rev: v1.5.1 | ||
hooks: | ||
- id: python-check-blanket-noqa | ||
|
||
- repo: https://github.com/PyCQA/isort | ||
rev: 5.12.0 | ||
hooks: | ||
- id: isort | ||
|
||
- repo: https://github.com/pycqa/flake8 | ||
rev: 4.0.1 | ||
hooks: | ||
- id: flake8 | ||
additional_dependencies: | ||
- flake8-docstrings~=1.6.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
Copyright 2021 Python Discord | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: | ||
|
||
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. | ||
|
||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,173 @@ | ||
# Python Discord Code Jam Repository Template | ||
|
||
## A Primer | ||
Hello code jam participants! We've put together this repository template for you to use in [our code jams](https://pythondiscord.com/events/) or even other Python events! | ||
|
||
This document will contain the following information: | ||
1. [What does this template contain?](#what-does-this-template-contain) | ||
2. [How do I use it?](#how-do-i-use-it) | ||
3. [How do I adapt it to my project?](#how-do-i-adapt-it-to-my-project) | ||
|
||
You can also look at [our style guide](https://pythondiscord.com/events/code-jams/code-style-guide/) to get more information about what we consider a maintainable code style. | ||
|
||
## What does this template contain? | ||
|
||
Here is a quick rundown of what each file in this repository contains: | ||
- `LICENSE`: [The MIT License](https://opensource.org/licenses/MIT), an OSS approved license which grants rights to everyone to use and modify your projects and limits your liability. We highly recommend you to read the license. | ||
- `.gitignore`: A list of files that will be ignored by Git. Most of them are auto-generated or contain data that you wouldn't want to share publicly. | ||
- `dev-requirements.txt`: Every PyPI packages used for the project's development, to ensure a common and maintainable code style. [More on that below](#using-the-default-pip-setup). | ||
- `tox.ini`: The configurations of two of our style tools: [`flake8`](https://pypi.org/project/flake8/) and [`isort`](https://pypi.org/project/isort/). | ||
- `.pre-commit-config.yaml`: The configuration of the [`pre-commit`](https://pypi.org/project/pre-commit/) tool. | ||
- `.github/workflows/lint.yaml`: A [GitHub Actions](https://github.com/features/actions) workflow, a set of actions run by GitHub on their server after each push, to ensure the style requirements are met. | ||
|
||
Each of these files have comments for you to understand easily, and modify to fit your needs. | ||
|
||
### flake8: general style rules | ||
|
||
Our first and probably most important tool is flake8. It will run a set of plugins on your codebase and warn you about any non-conforming lines. | ||
Here is a sample output: | ||
``` | ||
~> flake8 | ||
./app.py:1:6: N802 function name 'helloWorld' should be lowercase | ||
./app.py:1:16: E201 whitespace after '(' | ||
./app.py:2:1: D400 First line should end with a period | ||
./app.py:2:1: D403 First word of the first line should be properly capitalized | ||
./app.py:3:19: E225 missing whitespace around operator | ||
``` | ||
|
||
Each line corresponds to an error. The first part is the file path, then the line number, and the column index. | ||
Then comes the error code, a unique identifier of the error, and then a human-readable message. | ||
|
||
If, for any reason, you do not wish to comply with this specific error on a specific line, you can add `# noqa: CODE` at the end of the line. | ||
For example: | ||
```python | ||
def helloWorld(): # noqa: N802 | ||
... | ||
``` | ||
will pass linting. Although we do not recommend ignoring errors unless you have a good reason to do so. | ||
|
||
It is run by calling `flake8` in the project root. | ||
|
||
#### Plugin List: | ||
|
||
- `flake8-docstring`: Checks that you properly documented your code. | ||
|
||
### ISort: automatic import sorting | ||
|
||
This second tool will sort your imports according to the [PEP8](https://www.python.org/dev/peps/pep-0008/#imports). That's it! One less thing for you to do! | ||
|
||
It is run by calling `isort .` in the project root. Notice the dot at the end, it tells ISort to use the current directory. | ||
|
||
### Pre-commit: run linting before committing | ||
|
||
This third tool doesn't check your code, but rather makes sure that you actually *do* check it. | ||
|
||
It makes use of a feature called [Git hooks](https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks) which allow you to run a piece of code before running `git commit`. | ||
The good thing about it is that it will cancel your commit if the lint doesn't pass. You won't have to wait for Github Actions to report and have a second fix commit. | ||
|
||
It is *installed* by running `pre-commit install` and can be run manually by calling only `pre-commit`. | ||
|
||
[Lint before you push!](https://soundcloud.com/lemonsaurusrex/lint-before-you-push) | ||
|
||
#### Hooks List: | ||
|
||
- `check-toml`: Lints and corrects your TOML files. | ||
- `check-yaml`: Lints and corrects your YAML files. | ||
- `end-of-file-fixer`: Makes sure you always have an empty line at the end of your file. | ||
- `trailing-whitespaces`: Removes whitespaces at the end of each line. | ||
- `python-check-blanket-noqa`: Forbids you from using noqas on large pieces of code. | ||
- `isort`: Runs ISort. | ||
- `flake8`: Runs flake8. | ||
|
||
## How do I use it? | ||
|
||
### Creating your Team Repository | ||
|
||
One person in the team, preferably the leader, will have to create the repository and add other members as collaborators. | ||
|
||
1. In the top right corner of your screen, where **Clone** usually is, you have a **Use this template** button to click. | ||
|
||
 | ||
|
||
2. Give the repository a name and a description. | ||
|
||
 | ||
|
||
3. Click **Create repository from template**. | ||
|
||
4. Click **Settings** in your newly created repository. | ||
|
||
 | ||
|
||
5. In the "Access" section of the sidebar, click **Collaborators**. | ||
|
||
 | ||
|
||
6. Click **Add people**. | ||
|
||
7. Insert the names of each of your teammates, and invite them. Once they have accepted the invitation in their email, they will have write access to the repository. | ||
|
||
You are now ready to go! Now sit down, relax, and wait for the kickstart! | ||
Don't forget to swap "Python Discord" in the `LICENSE` file for the name of each of your team members or the name of your team after the start of the jam. | ||
|
||
### Using the Default Pip Setup | ||
|
||
Our default setup includes a bare requirement file to be used with a [virtual environment](https://docs.python.org/3/library/venv.html). | ||
|
||
We recommend this if you never have used any other dependency manager, although if you have, feel free to switch to it. More on that below. | ||
|
||
#### Creating the environment | ||
Create a virtual environment in the folder `.venv`. | ||
```shell | ||
$ python -m venv .venv | ||
``` | ||
|
||
#### Enter the environment | ||
It will change based on your operating system and shell. | ||
```shell | ||
# Linux, Bash | ||
$ source .venv/bin/activate | ||
# Linux, Fish | ||
$ source .venv/bin/activate.fish | ||
# Linux, Csh | ||
$ source .venv/bin/activate.csh | ||
# Linux, PowerShell Core | ||
$ .venv/bin/Activate.ps1 | ||
# Windows, cmd.exe | ||
> .venv\Scripts\activate.bat | ||
# Windows, PowerShell | ||
> .venv\Scripts\Activate.ps1 | ||
``` | ||
|
||
#### Installing the Dependencies | ||
Once the environment is created and activated, use this command to install the development dependencies. | ||
```shell | ||
$ pip install -r dev-requirements.txt | ||
``` | ||
|
||
#### Exiting the environment | ||
Interestingly enough, it is the same for every platform | ||
```shell | ||
$ deactivate | ||
``` | ||
|
||
Once the environment is activated, all the commands listed previously should work. We highly recommend that you run `pre-commit install` as soon as possible. | ||
|
||
## How do I adapt it to my project? | ||
|
||
If you wish to use Pipenv or Poetry, you will have to move the dependencies in `dev-requirements.txt` to the development dependencies of your tool. | ||
|
||
We've included a porting of `dev-requirements.txt` to both [poetry](./samples/pyproject.toml) and [pipenv](./samples/Pipfile) in the [samples folder](./samples). | ||
If you use the poetry setup, make sure to change the project name, description, and authors at the top of the file. | ||
|
||
When installing new dependencies, don't forget to [pin them](https://pip.pypa.io/en/stable/user_guide/#pinned-version-numbers) by adding a version tag at the end. | ||
For example, if I wish to install `Click`, a quick look at [PyPI](https://pypi.org/project/click/) tells me that 8.0.1 is the latest version. | ||
I will then add `click ~= 8.0`, without the last number, to my dependency manager. | ||
|
||
A code jam project is left unmaintained after the end of the event. If the dependencies aren't pinned, the project will break after the first major change in an API. | ||
|
||
## Final words | ||
|
||
Don't forget to replace this README with an actual description of your project! Images are also welcome! | ||
|
||
We hope this template will be helpful. Good luck in the jam! |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# This file contains all the development requirements for our linting toolchain. | ||
# Don't forget to pin your dependencies! | ||
# This list will have to be migrated if you wish to use another dependency manager. | ||
|
||
# Base tools | ||
flake8~=4.0.1 | ||
isort~=5.10.1 | ||
pre-commit~=2.17.0 | ||
|
||
# Flake8 plugins, see https://github.com/python-discord/code-jam-template/tree/main#plugin-list | ||
flake8-docstrings~=1.6.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
[[source]] | ||
url = "https://pypi.org/simple" | ||
verify_ssl = true | ||
name = "pypi" | ||
|
||
[packages] | ||
|
||
[dev-packages] | ||
# Base tools | ||
flake8 = "~=4.0.1" | ||
isort = "~=5.12.0" | ||
pre-commit = "~=2.17.0" | ||
|
||
# Flake8 plugins, see https://github.com/python-discord/code-jam-template/tree/main#plugin-list | ||
flake8-docstrings = "~=1.6.0" | ||
|
||
[requires] | ||
python_version = "3.10" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
[tool.poetry] | ||
name = "Name" | ||
version = "0.1.0" | ||
description = "" | ||
authors = ["Author 1 <[email protected]>"] | ||
license = "MIT" | ||
|
||
[tool.poetry.dependencies] | ||
python = "3.10.*" | ||
|
||
[tool.poetry.dev-dependencies] | ||
# Base tools | ||
flake8 = "~4.0.1" | ||
isort = "~5.12.0" | ||
pre-commit = "~2.17.0" | ||
|
||
# Flake8 plugins, see https://github.com/python-discord/code-jam-template/tree/main#plugin-list | ||
flake8-docstrings = "~1.6.0" | ||
|
||
|
||
[build-system] | ||
requires = ["poetry-core>=1.0.0"] | ||
build-backend = "poetry.core.masonry.api" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
# Flake8 and ISort configuration | ||
|
||
[flake8] | ||
# Increase the line length. This breaks PEP8 but it is way easier to work with. | ||
# The original reason for this limit was a standard vim terminal is only 79 characters, | ||
# but this doesn't really apply anymore. | ||
max-line-length=119 | ||
# Don't lint the venv or the CPython cache. | ||
exclude=.venv,__pycache__ | ||
# Ignore some of the most obnoxious linting errors. | ||
ignore= | ||
W503,E226, | ||
# Missing Docstrings | ||
D100,D104,D105,D106,D107, | ||
# Docstring Whitespace | ||
D203,D212,D214,D215, | ||
# Docstring Quotes | ||
D301,D302, | ||
# Docstring Content | ||
D400,D401,D402,D404,D405,D406,D407,D408,D409,D410,D411,D412,D413,D414,D416,D417, | ||
# Comments | ||
E266 | ||
|
||
[isort] | ||
# Select the 5th style (Hanging grid grouped) to handle longer import. | ||
# This choice is mostly arbitrary and can be changed at your will. | ||
# | ||
# Example of this style: | ||
# from third_party import ( | ||
# lib1, lib2, lib3, lib4, | ||
# lib5, ... | ||
# ) | ||
multi_line_output=5 |