Skip to content

Commit

Permalink
Merge pull request #63 from thin-edge/chore-update-te-remove-workarounds
Browse files Browse the repository at this point in the history
chore: remove workarounds after related tickets have been merged
  • Loading branch information
reubenmiller authored Dec 16, 2023
2 parents dd6afc4 + 1fac462 commit 5f97635
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 38 deletions.
9 changes: 0 additions & 9 deletions demos/docker-compose/tedge-containermgmt/docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ x-device-defaults: &defaults
- /tmp
depends_on:
- mqtt-broker
environment:
# Remove once: https://github.com/thin-edge/thin-edge.io/issues/2523
- TEDGE_ENABLE_SUDO=false
# root is required in the default docker setup
user: root

Expand Down Expand Up @@ -50,8 +47,6 @@ services:
- TEDGE_C8Y_URL=${C8Y_DOMAIN:-}
volumes:
- device-certs:/etc/tedge/device-certs
# Remove once https://github.com/thin-edge/thin-edge.io/issues/2477 is resolved
- tedge-data:/var/tedge

# main device
tedge:
Expand All @@ -60,8 +55,6 @@ services:
volumes:
# Enable docker from docker - But then this container has elevated access to system resources!
- /var/run/docker.sock:${DOCKER_SOCKET:-/var/run/docker.sock}:rw
# Remove once https://github.com/thin-edge/thin-edge.io/issues/2477 is resolved
- tedge-data:/var/tedge

# monitor container/container-groups and add services on the main device
tedge-container-monitor:
Expand All @@ -75,5 +68,3 @@ volumes:
device-certs:
mosquitto:
mosquitto-conf:
# Remove once https://github.com/thin-edge/thin-edge.io/issues/2477 is resolved
tedge-data:
10 changes: 0 additions & 10 deletions demos/docker-compose/tedge/docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ x-device-defaults: &defaults
- /tmp
depends_on:
- mqtt-broker
environment:
# Remove once: https://github.com/thin-edge/thin-edge.io/issues/2523
- TEDGE_ENABLE_SUDO=false

services:
bootstrap:
Expand Down Expand Up @@ -48,16 +45,11 @@ services:
- TEDGE_C8Y_URL=${C8Y_DOMAIN:-}
volumes:
- device-certs:/etc/tedge/device-certs
# Remove once https://github.com/thin-edge/thin-edge.io/issues/2477 is resolved
- tedge-data:/var/tedge

# main device
tedge:
<<: *defaults
command: ["/usr/bin/tedge-agent", "--mqtt-device-topic-id", "device/main//"]
volumes:
# Remove once https://github.com/thin-edge/thin-edge.io/issues/2477 is resolved
- tedge-data:/var/tedge

# child devices
child01:
Expand All @@ -68,5 +60,3 @@ volumes:
device-certs:
mosquitto:
mosquitto-conf:
# Remove once https://github.com/thin-edge/thin-edge.io/issues/2477 is resolved
tedge-data:
9 changes: 0 additions & 9 deletions images/tedge-containermgmt/docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ x-device-defaults: &defaults
- /tmp
depends_on:
- mqtt-broker
environment:
# Remove once: https://github.com/thin-edge/thin-edge.io/issues/2523
- TEDGE_ENABLE_SUDO=false
# root is required in the default docker setup
user: root

Expand Down Expand Up @@ -52,8 +49,6 @@ services:
- TEDGE_C8Y_URL=${C8Y_DOMAIN:-}
volumes:
- device-certs:/etc/tedge/device-certs
# Remove once https://github.com/thin-edge/thin-edge.io/issues/2477 is resolved
- tedge-data:/var/tedge

# main device
tedge:
Expand All @@ -62,8 +57,6 @@ services:
volumes:
# Enable docker from docker - But then this container has elevated access to system resources!
- /var/run/docker.sock:${DOCKER_SOCKET:-/var/run/docker.sock}:rw
# Remove once https://github.com/thin-edge/thin-edge.io/issues/2477 is resolved
- tedge-data:/var/tedge

# monitor container/container-groups and add services on the main device
tedge-container-monitor:
Expand All @@ -77,5 +70,3 @@ volumes:
device-certs:
mosquitto:
mosquitto-conf:
# Remove once https://github.com/thin-edge/thin-edge.io/issues/2477 is resolved
tedge-data:
10 changes: 0 additions & 10 deletions images/tedge/docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ x-device-defaults: &defaults
- /tmp
depends_on:
- mqtt-broker
environment:
# Remove once: https://github.com/thin-edge/thin-edge.io/issues/2523
- TEDGE_ENABLE_SUDO=false

services:
bootstrap:
Expand Down Expand Up @@ -50,16 +47,11 @@ services:
- TEDGE_C8Y_URL=${C8Y_DOMAIN:-}
volumes:
- device-certs:/etc/tedge/device-certs
# Remove once https://github.com/thin-edge/thin-edge.io/issues/2477 is resolved
- tedge-data:/var/tedge

# main device
tedge:
<<: *defaults
command: ["/usr/bin/tedge-agent", "--mqtt-device-topic-id", "device/main//"]
volumes:
# Remove once https://github.com/thin-edge/thin-edge.io/issues/2477 is resolved
- tedge-data:/var/tedge

# child devices
child01:
Expand All @@ -70,5 +62,3 @@ volumes:
device-certs:
mosquitto:
mosquitto-conf:
# Remove once https://github.com/thin-edge/thin-edge.io/issues/2477 is resolved
tedge-data:

4 comments on commit 5f97635

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
15 0 0 15 100 2m36.981s

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
11 0 2 11 100 51.407999999s

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
15 0 0 15 100 2m39.92s

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
11 0 2 11 100 51.313999999s

Please sign in to comment.