Skip to content

Commit

Permalink
Revert "Remove section on auto-close functionality"
Browse files Browse the repository at this point in the history
After discussion we agreed to not remove this paragraph for now.

This reverts commit 115d23a.

Suggested-by: Didier Wenzek <[email protected]>
Signed-off-by: Matthias Beyer <[email protected]>
  • Loading branch information
matthiasbeyer committed Sep 1, 2022
1 parent 65e7435 commit 235c78e
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ When possible, fill out as much detail in the pull request template as is
reasonable. Most important is to reference the GitHub issue that you are
addressing with the PR.

**NOTE:** GitHub has [a feature](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)
that will automatically close issues referenced with a keyword (such as "Fixes")
by a PR or commit once the PR/commit is merged. Don't use these keywords. We
don't want issues to be automatically closed. We want our testers to
independently verify and close them.

## Writing good commit messages

Having clear, concise and well-written commit messages for all changes is not
Expand Down

0 comments on commit 235c78e

Please sign in to comment.