Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove usage of actions-rs/toolchain@v1 as it is not actively maintained #1999

Merged
merged 1 commit into from
Jun 2, 2023
Merged

ci: remove usage of actions-rs/toolchain@v1 as it is not actively maintained #1999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/pull-request-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,11 @@ jobs:
- uses: actions/checkout@v3

- name: Install nightly toolchain
uses: actions-rs/toolchain@v1
id: toolchain
uses: dtolnay/rust-toolchain@master
with:
toolchain: nightly
override: true
- run: rustup override set ${{steps.toolchain.outputs.name}}

- name: Run cargo-udeps
uses: aig787/cargo-udeps-action@v1
Expand Down Expand Up @@ -202,12 +203,17 @@ jobs:
uses: actions/checkout@v3

# Nightly toolchain is needed for cargo fmt since issue: https://github.com/thin-edge/thin-edge.io/issues/1660
# dtolnay/rust-toolchain is preferred over actions-rs/toolchain is currently not maintained and currently using
# deprecated GHA api (see https://github.com/actions-rs/toolchain/issues/219).
# However since dtolnay/rust-toolchain does not support the 'override' option, an additional call to
# rustup override is required (see https://github.com/dtolnay/rust-toolchain/issues/29#issuecomment-1412903426)
- name: Install nightly toolchain
uses: actions-rs/toolchain@v1
id: toolchain
uses: dtolnay/rust-toolchain@master
with:
toolchain: nightly
components: rustfmt
override: true
- run: rustup override set ${{steps.toolchain.outputs.name}}

- name: Cargo fmt --version
uses: actions-rs/cargo@v1
Expand Down