Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support publishing measurements to services #2333

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Add support for publishing measurements to services on the main and child devices:

Task list:

  • Implementation in Rust to publish measurements to services on main device
  • Implementation in Rust to publish measurements to services on child devices
  • System tests to verify publishing of all telemetry types (measurements, events and alarms) to services on the main and child devices

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2332

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller
Copy link
Contributor Author

System tests have been added to verify the future implementation and it includes system tests validating all types of telemetry data being published to services on the main and child devices.

@reubenmiller reubenmiller added the theme:telemetry Theme: Telemetry data label Oct 11, 2023
@reubenmiller reubenmiller marked this pull request as draft October 11, 2023 04:18
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
322 4 3 326 98.77 1h1m44.072999999s

Failed Tests

Name Message ⏱️ Duration Suite
Send measurements to an unregistered child service not enough measurements were found. args=() 33.432 s Child Device Telemetry
Send measurements to a registered child service not enough measurements were found. args=() 33.406 s Child Device Telemetry
Send measurements to an unregistered service not enough measurements were found. args=() 33.601 s Thin-Edge Device Telemetry
Send measurements to a registered service not enough measurements were found. args=() 33.855 s Thin-Edge Device Telemetry

@PradeepKiruvale PradeepKiruvale force-pushed the issue-2332-service-measurements branch from 69705ac to 9a3c532 Compare October 11, 2023 10:31
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #2333 (9a3c532) into main (4fc84df) will decrease coverage by 0.1%.
Report is 2 commits behind head on main.
The diff coverage is 84.4%.

❗ Current head 9a3c532 differs from pull request most recent head 69705ac. Consider uploading reports for the commit 69705ac to get more accurate results

Additional details and impacted files
Files Coverage Δ
crates/common/tedge_config_macros/impl/src/lib.rs 95.2% <100.0%> (ø)
...rates/common/tedge_config_macros/impl/src/query.rs 95.2% <100.0%> (+1.7%) ⬆️
crates/core/tedge_watchdog/src/error.rs 0.0% <ø> (ø)
crates/extensions/c8y_mapper_ext/src/serializer.rs 81.2% <100.0%> (ø)
...common/tedge_config_macros/impl/src/input/parse.rs 39.7% <0.0%> (-0.6%) ⬇️
...mon/tedge_config_macros/impl/src/input/validate.rs 94.3% <94.7%> (+0.2%) ⬆️
crates/core/tedge_api/src/health.rs 84.9% <81.5%> (+10.7%) ⬆️
crates/core/tedge_watchdog/src/systemd_watchdog.rs 25.4% <76.3%> (+8.3%) ⬆️

... and 5 files with indirect coverage changes

@reubenmiller reubenmiller force-pushed the issue-2332-service-measurements branch from 9a3c532 to 69705ac Compare October 11, 2023 10:49
@reubenmiller
Copy link
Contributor Author

Closed as duplicate of #2335

@reubenmiller reubenmiller deleted the issue-2332-service-measurements branch July 18, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:telemetry Theme: Telemetry data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants