-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "upload HEAD coverage" workflow #2679
Remove "upload HEAD coverage" workflow #2679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Robot Results
|
@Bravo555 does it make sense to consolidate this workflow with the Pull Request Checks, as it seems like a duplication to me...if so, can you create a new ticket to remove the duplication in function? |
569ab6c
to
191d7d7
Compare
As we have started using the merge queue which is the new "future main" and merge by squashing is also no longer possible, the workflow is no longer necessary. Signed-off-by: Marcel Guzik <[email protected]>
191d7d7
to
4db4770
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Good to remove duplication (and using unnecessary runner resources).
Proposed changes
As we have started using the merge queue which is the new "future main" and merge by squashing is also no longer possible, the workflow is no longer necessary.
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments