Replace special characters in package version

[Ruadhri17]

Proposed changes

This PR provides a quick fix to the tedge-apt-plugin bug, which prevents the package installation if it contains a colon character. More in #2666.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
• Documentation Update (if none of the other choices apply)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

• debian software package does not install from url when version contains a colon character #2666

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA (in all commits with git commit -s)
• I ran cargo fmt as mentioned in CODING_GUIDELINES
• I used cargo clippy as mentioned in CODING_GUIDELINES
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4347525) 75.9% compared to head (153b90f) 75.9%.
Report is 9 commits behind head on main.

Additional details and impacted files

Files	Coverage Δ
crates/core/plugin_sm/src/plugin.rs	15.7% <100.0%> (+3.9%)	⬆️

... and 1 file with indirect coverage changes

[github-actions]

Robot Results

✅ Passed	❌ Failed	⏭️ Skipped	Total	Pass %	⏱️ Duration
391	0	3	391	100	50m40.018s

[didier-wenzek]

Software not installed. errors=[('package-with-epoch', 'MISSING')]

You have to add package-with-epoch to the list of packages not filtered out by the tedge-apt-plugin.

[reubenmiller]

Software not installed. errors=[('package-with-epoch', 'MISSING')]

You have to add package-with-epoch to the list of packages not filtered out by the tedge-apt-plugin.

Good point. I overlooked this…or maybe we could modify the default setting to include a naming convention or even better filter by maintainer

[reubenmiller]

Tests (including generation of test files) looks good.

[reubenmiller]

@Ruadhri17
The reason why the Apply name filter test is now failing is because the default maintainer filter was added to the base integration test image, and in this test it is calling the tedge-apt-plugin list command manually which is inheriting the maintainer filter from the tedge.toml (which previously did not exist). So we just need to prevent that from happening by using --maintainer "" in the test.

Here is the git patch to fix the issue:

diff --git a/tests/RobotFramework/tests/plugin_apt/filter_packages_list_output.robot b/tests/RobotFramework/tests/plugin_apt/filter_packages_list_output.robot
index b921944f5e..12e74768ce 100644
--- a/tests/RobotFramework/tests/plugin_apt/filter_packages_list_output.robot
+++ b/tests/RobotFramework/tests/plugin_apt/filter_packages_list_output.robot
@@ -11,7 +11,7 @@ Test Tags           theme:software    theme:plugins
 *** Test Cases ***
 Apply name filter
     ${packages_list}=    Execute Command
-    ...    sudo /etc/tedge/sm-plugins/apt list --name tedge
+    ...    sudo /etc/tedge/sm-plugins/apt list --name tedge --maintainer ""
     ...    exp_exit_code=0
     Should Match Regexp    ${packages_list}    ^tedge\\s+${VERSION}

[didier-wenzek]

Approved

[reubenmiller]

@Ruadhri17 The reason why the Apply name filter test is now failing is because the default maintainer filter was added to the base integration test image, and in this test it is calling the tedge-apt-plugin list command manually which is inheriting the maintainer filter from the tedge.toml (which previously did not exist). So we just need to prevent that from happening by using --maintainer "" in the test.

Here is the git patch to fix the issue:

diff --git a/tests/RobotFramework/tests/plugin_apt/filter_packages_list_output.robot b/tests/RobotFramework/tests/plugin_apt/filter_packages_list_output.robot
index b921944f5e..12e74768ce 100644
--- a/tests/RobotFramework/tests/plugin_apt/filter_packages_list_output.robot
+++ b/tests/RobotFramework/tests/plugin_apt/filter_packages_list_output.robot
@@ -11,7 +11,7 @@ Test Tags           theme:software    theme:plugins
 *** Test Cases ***
 Apply name filter
     ${packages_list}=    Execute Command
-    ...    sudo /etc/tedge/sm-plugins/apt list --name tedge
+    ...    sudo /etc/tedge/sm-plugins/apt list --name tedge --maintainer ""
     ...    exp_exit_code=0
     Should Match Regexp    ${packages_list}    ^tedge\\s+${VERSION}

I was able to apply the patch myself (after disabling the git-lfs pre-commit hook which was previously blocking me to do so)