Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(system): update c8y system test lib to improve retry logging #2931

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Jun 11, 2024

Proposed changes

Update the robotframework-c8y library (used in system tests), to improve the logging of the "smart retry" feature. This should help improve debugging of tests to show an assertions number of attempts, and the output of each failed attempt.

Example

The following snippet shows the new info log entries showing that Managed Object Should Have Fragment Values assertion was attempted a few times before it passed.

image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller requested review from gligorisaev and a team as code owners June 11, 2024 07:29
@reubenmiller reubenmiller temporarily deployed to Test Pull Request June 11, 2024 07:29 — with GitHub Actions Inactive
@reubenmiller reubenmiller changed the title test: update c8y system test lib to improve retry logging test(system): update c8y system test lib to improve retry logging Jun 11, 2024
Copy link
Contributor

github-actions bot commented Jun 11, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
452 0 3 452 100 1h10m50.365512s

@reubenmiller reubenmiller temporarily deployed to Test Pull Request June 11, 2024 09:58 — with GitHub Actions Inactive
@reubenmiller reubenmiller added this pull request to the merge queue Jun 11, 2024
Merged via the queue into thin-edge:main with commit 58c2812 Jun 11, 2024
31 checks passed
@reubenmiller reubenmiller deleted the chore-update-c8y-test-lib branch July 18, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants