-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Parse root certificate from either file or directory in tedge cert upload #2953
fix: Parse root certificate from either file or directory in tedge cert upload #2953
Conversation
Robot Results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
@jarhodes314 I created test case that should cover the bug #2951, but not being yet able to check if it will pass after installing the final build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
…load Signed-off-by: James Rhodes <[email protected]>
Signed-off-by: James Rhodes <[email protected]>
Signed-off-by: James Rhodes <[email protected]>
Signed-off-by: James Rhodes <[email protected]>
Signed-off-by: James Rhodes <[email protected]>
Signed-off-by: James Rhodes <[email protected]>
Signed-off-by: James Rhodes <[email protected]>
Signed-off-by: James Rhodes <[email protected]>
Signed-off-by: gligorisaev <[email protected]>
963bd5e
to
e637b25
Compare
Proposed changes
This PR ensures the
c8y.root_cert_path
setting is respected in all places tedge makes an HTTP connection to Cumulocity. The setting previously existed but wasn't widely respected, meaning that operations such as retrieving a configuration file or remote access didn't work unless the Cumulocity root certificate was trusted by the system. Following these changes, it should be sufficient to setc8y.root_cert_path
to point to the Cumulocity root certificate and all operations as well as commands liketedge cert upload
should work.This also fixes a separate issue with
tedge cert upload
where it did respect the setting, but always read the configuration from/etc/tedge/tedge.toml
, rather than using the provided custom configuration directory.Types of changes
Paste Link to the issue
#2951
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments