-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add a custom command based log_upload workflow #2983
Merged
reubenmiller
merged 1 commit into
thin-edge:main
from
reubenmiller:test-custom-command-based-log_upload
Jul 11, 2024
Merged
test: add a custom command based log_upload workflow #2983
reubenmiller
merged 1 commit into
thin-edge:main
from
reubenmiller:test-custom-command-based-log_upload
Jul 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reubenmiller
requested review from
Bravo555,
didier-wenzek,
albinsuresh,
jarhodes314,
rina23q,
gligorisaev and
a team
as code owners
July 8, 2024 16:37
reubenmiller
had a problem deploying
to
Test Pull Request
July 8, 2024 16:37 — with
GitHub Actions
Failure
reubenmiller
had a problem deploying
to
Test Pull Request
July 8, 2024 16:38 — with
GitHub Actions
Failure
reubenmiller
force-pushed
the
test-custom-command-based-log_upload
branch
from
July 8, 2024 16:42
af19dbe
to
4c2dd2a
Compare
reubenmiller
temporarily deployed
to
Test Pull Request
July 8, 2024 16:43 — with
GitHub Actions
Inactive
reubenmiller
added
theme:troubleshooting
Theme: Troubleshooting and remote control
theme:testing
theme:workflows
labels
Jul 8, 2024
Robot Results
|
tests/RobotFramework/tests/cumulocity/log/workflow/tedge-log-plugin.toml
Outdated
Show resolved
Hide resolved
reubenmiller
temporarily deployed
to
Test Pull Request
July 9, 2024 08:40 — with
GitHub Actions
Inactive
didier-wenzek
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
gligorisaev
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Test is doing what is supposed to do
reubenmiller
force-pushed
the
test-custom-command-based-log_upload
branch
from
July 11, 2024 15:43
4865f43
to
f9518af
Compare
reubenmiller
temporarily deployed
to
Test Pull Request
July 11, 2024 15:43 — with
GitHub Actions
Inactive
Signed-off-by: Reuben Miller <[email protected]>
reubenmiller
force-pushed
the
test-custom-command-based-log_upload
branch
from
July 11, 2024 16:25
f9518af
to
0ca9227
Compare
reubenmiller
temporarily deployed
to
Test Pull Request
July 11, 2024 16:25 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add a system tests which can demonstrate how to handle command based log_upload commands by overriding the default log_upload workflow, and add a pre-processing step which will generate the log file when called (the command could do something like talk to a database etc.)
It shows a working example that can be referenced to customers.
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments