Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add a custom command based log_upload workflow #2983

Merged

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Add a system tests which can demonstrate how to handle command based log_upload commands by overriding the default log_upload workflow, and add a pre-processing step which will generate the log file when called (the command could do something like talk to a database etc.)

It shows a working example that can be referenced to customers.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Contributor

github-actions bot commented Jul 8, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
476 0 3 476 100 1h14m21.839582999s

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

@gligorisaev gligorisaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Test is doing what is supposed to do

@reubenmiller reubenmiller force-pushed the test-custom-command-based-log_upload branch from 4865f43 to f9518af Compare July 11, 2024 15:43
@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 11, 2024 15:43 — with GitHub Actions Inactive
@reubenmiller reubenmiller force-pushed the test-custom-command-based-log_upload branch from f9518af to 0ca9227 Compare July 11, 2024 16:25
@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 11, 2024 16:25 — with GitHub Actions Inactive
@reubenmiller reubenmiller enabled auto-merge July 11, 2024 16:29
@reubenmiller reubenmiller added this pull request to the merge queue Jul 11, 2024
Merged via the queue into thin-edge:main with commit 80d2a54 Jul 11, 2024
31 checks passed
@reubenmiller reubenmiller deleted the test-custom-command-based-log_upload branch July 18, 2024 13:37
@reubenmiller reubenmiller restored the test-custom-command-based-log_upload branch July 18, 2024 13:37
@reubenmiller reubenmiller deleted the test-custom-command-based-log_upload branch July 18, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:testing theme:troubleshooting Theme: Troubleshooting and remote control theme:workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants