Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reset mqtt.bridge.built_in setting to default value #3023

Merged

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Prevent an inadvertent change of the mqtt.bridge.built_in setting at the end of a test by unsetting the value instead of setting it to an explicit value (and using an official [Teardown] hook so it is always executed regardless if the test passes or fails).

Technically the test flaky is present due to an unknown issue in the builtin bridge, however this issue will be addressed in another PR, #2911.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller requested review from gligorisaev and a team as code owners July 29, 2024 20:30
@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 29, 2024 20:30 — with GitHub Actions Inactive
@reubenmiller reubenmiller changed the title test: reset built_in setting to default value test: reset mqtt.bridge.built_in setting to default value Jul 29, 2024
@reubenmiller reubenmiller added theme:mqtt Theme: mqtt and mosquitto related topics theme:testing labels Jul 29, 2024
@reubenmiller reubenmiller force-pushed the test-connection-wrongstate branch from 144f7fa to 9d3f6c0 Compare July 29, 2024 20:34
@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 29, 2024 20:34 — with GitHub Actions Inactive
Copy link
Contributor

github-actions bot commented Jul 29, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
486 0 2 486 100 1h25m23.635279999s

@reubenmiller reubenmiller force-pushed the test-connection-wrongstate branch from 9d3f6c0 to ec94bb3 Compare July 30, 2024 05:52
@reubenmiller reubenmiller added this pull request to the merge queue Jul 30, 2024
Merged via the queue into thin-edge:main with commit 123e1d4 Jul 30, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release-notes theme:mqtt Theme: mqtt and mosquitto related topics theme:testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants