-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: increase delay in workaround for flaky unit test #3026
Closed
reubenmiller
wants to merge
1
commit into
thin-edge:main
from
reubenmiller:test-bridge_reconnects_successfully_after_local_connection_interrupted
Closed
test: increase delay in workaround for flaky unit test #3026
reubenmiller
wants to merge
1
commit into
thin-edge:main
from
reubenmiller:test-bridge_reconnects_successfully_after_local_connection_interrupted
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reubenmiller
requested review from
didier-wenzek,
albinsuresh,
jarhodes314 and
rina23q
as code owners
July 30, 2024 08:56
reubenmiller
temporarily deployed
to
Test Pull Request
July 30, 2024 08:56 — with
GitHub Actions
Inactive
Bravo555
approved these changes
Jul 30, 2024
reubenmiller
temporarily deployed
to
Test Pull Request
July 30, 2024 09:15 — with
GitHub Actions
Inactive
Robot Results
|
Signed-off-by: Reuben Miller <[email protected]>
reubenmiller
force-pushed
the
test-bridge_reconnects_successfully_after_local_connection_interrupted
branch
from
July 30, 2024 09:37
e9271af
to
4d46c4d
Compare
reubenmiller
temporarily deployed
to
Test Pull Request
July 30, 2024 09:37 — with
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 30, 2024
rina23q
approved these changes
Jul 30, 2024
we'll have to change strategy here, as the test is still failing sporadically. Once #3027 is merged, I will rebase this PR, and configure the retries feature to retry the problematic test several times. |
Closing PR as the test has been marked for retries when run using cargo-nextest. #3027 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Increase the delay in the workaround due to (#3021), after the following CI run failure was detected:
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments