Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase delay in workaround for flaky unit test #3026

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Increase the delay in the workaround due to (#3021), after the following CI run failure was detected:

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 30, 2024 09:15 — with GitHub Actions Inactive
Copy link
Contributor

github-actions bot commented Jul 30, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
486 0 2 486 100 1h18m15.550296s

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.1%. Comparing base (e7c43aa) to head (4d46c4d).
Report is 3 commits behind head on main.

Additional details and impacted files

see 3 files with indirect coverage changes

@reubenmiller reubenmiller force-pushed the test-bridge_reconnects_successfully_after_local_connection_interrupted branch from e9271af to 4d46c4d Compare July 30, 2024 09:37
@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 30, 2024 09:37 — with GitHub Actions Inactive
@reubenmiller reubenmiller enabled auto-merge July 30, 2024 09:53
@reubenmiller reubenmiller added this pull request to the merge queue Jul 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2024
@reubenmiller
Copy link
Contributor Author

we'll have to change strategy here, as the test is still failing sporadically. Once #3027 is merged, I will rebase this PR, and configure the retries feature to retry the problematic test several times.

@reubenmiller
Copy link
Contributor Author

Closing PR as the test has been marked for retries when run using cargo-nextest. #3027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants