Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: changelog formatting and classification improvements #3040

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Aug 1, 2024

Proposed changes

Minor improvements to the formatting and classification rules used in the changelog generation (done by git-cliff):

  • Limit scope of matching a message against a group by matching against <scope>(.+)?: to prevent matching against the description
  • Add PR number check before returning the link to the PR

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller temporarily deployed to Test Pull Request August 1, 2024 08:37 — with GitHub Actions Inactive
@reubenmiller reubenmiller added the ci/cd Repository management and pipeline topics label Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
489 0 2 489 100 1h26m6.333075s

@reubenmiller reubenmiller added this pull request to the merge queue Aug 1, 2024
Merged via the queue into thin-edge:main with commit cb07dc9 Aug 1, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Repository management and pipeline topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants