Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Subscribe to C8Y topics using QoS 1 #3201

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

didier-wenzek
Copy link
Contributor

Proposed changes

Subscribe to C8Y topics using QoS 1

  • There is no point to use QoS 2 as the session is cleared on each reconnect
  • The builtin bridge is already using QoS 1

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@didier-wenzek didier-wenzek added theme:c8y Theme: Cumulocity related topics theme:bridge Built-in (Rust) bridge topics labels Oct 24, 2024
@didier-wenzek didier-wenzek marked this pull request as ready for review October 24, 2024 08:41
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files

📢 Thoughts on this report? Let us know!

Copy link
Contributor

github-actions bot commented Oct 24, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
528 0 2 528 100 1h32m31.035133s

@reubenmiller
Copy link
Contributor

This might help avoid situations where the local bridge is waiting for a response from the server but it never arrives. #3141

Copy link
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Makes a lot of sense, and hopefully reduces scenarios like #3141

@didier-wenzek didier-wenzek added this pull request to the merge queue Oct 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2024
- There is no point to use QoS 2 as the session is cleared on each
  reconnect
- The builtin bridge is already using QoS 1

Signed-off-by: Didier Wenzek <[email protected]>
Copy link
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@didier-wenzek didier-wenzek added this pull request to the merge queue Oct 30, 2024
Merged via the queue into thin-edge:main with commit ecb0fff Oct 30, 2024
33 checks passed
@didier-wenzek didier-wenzek deleted the fix/c8y-bridge-qos branch October 30, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:bridge Built-in (Rust) bridge topics theme:c8y Theme: Cumulocity related topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants