-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Subscribe to C8Y topics using QoS 1 #3201
fix: Subscribe to C8Y topics using QoS 1 #3201
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files📢 Thoughts on this report? Let us know! |
Robot Results
|
This might help avoid situations where the local bridge is waiting for a response from the server but it never arrives. #3141 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Makes a lot of sense, and hopefully reduces scenarios like #3141
- There is no point to use QoS 2 as the session is cleared on each reconnect - The builtin bridge is already using QoS 1 Signed-off-by: Didier Wenzek <[email protected]>
6e14918
to
d5d28f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Proposed changes
Subscribe to C8Y topics using QoS 1
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments