Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typos #3312

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix: Fix typos #3312

merged 1 commit into from
Jan 3, 2025

Conversation

rina23q
Copy link
Member

@rina23q rina23q commented Jan 2, 2025

Proposed changes

The pull request check "Spell Check with Typos" started failing now. example run

I cherry-picked the commit a23796e from the PR #3311.
Since these typos are unrelated to all opened PRs, I think it would be more helpful to merge the fixing typo part only now.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Didier Wenzek <[email protected]>
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@rina23q rina23q changed the title Fix typos fix: Fix typos Jan 2, 2025
@rina23q rina23q enabled auto-merge January 2, 2025 20:42
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files

📢 Thoughts on this report? Let us know!

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
551 0 2 551 100 1h28m53.336114999s

@rina23q rina23q added this pull request to the merge queue Jan 3, 2025
Merged via the queue into thin-edge:main with commit 07bf931 Jan 3, 2025
33 checks passed
@rina23q rina23q deleted the fix-typo branch January 3, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants