Random color generator tushar raval #1108
Conversation
|
@TusharRaval |
https://tusharraval.github.io/MoviePlayer/ kindly review this |
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Mp3/Video Player</title> | ||
| </head> | ||
| <script src="style.css"></script> |
There was a problem hiding this comment.
<!-- Linking the stylesheet. -->
<link rel="stylesheet" href="style.css">| <source src="https://mainline.i3s.unice.fr/mooc/mi5.mp4" /> | ||
| </video> | ||
| <div> | ||
| <button type="button" id="pl">Play</button> |
There was a problem hiding this comment.
Use a formatter before saving and pushing.
| <button type="button"> <span id="volDown">- </span>Vol<span id="volUp"> +</span></button> | ||
| </div> | ||
| <div class="thumbs"> | ||
| <img id="vid1" src="https://i.imgur.com/y6RTkIi.gif" width="128" height="72" alt="video 1"> |
There was a problem hiding this comment.
Using local assets can improve performance by reducing reliance
|
|
||
| <div class="player"> | ||
| <video id="myVideo" preload width="640" height="360"> | ||
| <source src="https://mainline.i3s.unice.fr/mooc/mi5.mp4" /> |
There was a problem hiding this comment.
Use non-copyright material, please.
| var vid3 = document.getElementById("vid3"); | ||
|
|
||
| var sources = ["https://mainline.i3s.unice.fr/mooc/mi5.mp4", | ||
| "https://mainline.i3s.unice.fr/mooc/ff7.mp4", |
There was a problem hiding this comment.
use non-copyright material only.
There was a problem hiding this comment.
use assets folder and input the img and videos files there.
There was a problem hiding this comment.
Please read the README.md of the repository, carefully. Especially the Important tagged points.
This time it's an exception. Neglecting the execution of fifth point.
But 6th Point is crucially compulsory for every project.
There was a problem hiding this comment.
Embed into README.md of the project.
There was a problem hiding this comment.
Embed into README.md of the project.
| <h4 id="text">#000000</h4> | ||
| <p>click to change color</p> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
@TusharRaval
No README.md provided. No screenshots attached.
No live link to it.
A very laid back approach to submission. Next time it will be completely rejected. Beware!
@NitkarshChourasia
There was a problem hiding this comment.
Are you sure you made this project?
Are you plagiarizing it?
Developer Checklist
Summary
random color generator by with hexa values
add a summary here
Screenshot
attach screenshots/gifs here
Live Project Link
https://tusharraval.github.io/Random-color-generator/
add a working project link here