Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default options for connections #26

Merged
merged 1 commit into from
Mar 16, 2024
Merged

Conversation

TwistingTwists
Copy link
Contributor

@TwistingTwists TwistingTwists commented Feb 29, 2024

  • use correct window_size for Mint HTTP opts.

@@ -33,6 +37,7 @@ base64_image = "data:image/png;base64," <> Base.encode64(image)

defmodule Product do
use Ecto.Schema
use Instructor.Validator
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? there aren't any validations in this example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. that's why! I thought it was necessary to use Instructor.Validator. Now i know better.

@TwistingTwists TwistingTwists changed the title Update gpt4-vision.livemd default options for connections Mar 7, 2024
@TwistingTwists
Copy link
Contributor Author

TwistingTwists commented Mar 9, 2024

@thmsmlr : Can you please review the changes and merge if everything looks ok ?

I think many people have been facing this issue. see : #31 (comment)

@thmsmlr thmsmlr merged commit 1e4d453 into thmsmlr:main Mar 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants