optimize the sparse HNF, some startegy, but mostly gc friendly #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fieker
commented
Feb 21, 2025
fieker
commented
- add temporary scalar variables in SMat
- use (and define) more ! functions
- careful memory management in ZZRow
- improve sub, transpose, ..
- add strategy in HNF to alternate between full HNF and only produce some upper triangular matrix
- better support for getting the trafo by appending the identity
- add temporary scalar variables in SMat - use (and define) more ! functions - careful memory management in ZZRow - improve sub, transpose, .. - add strategy in HNF to alternate between full HNF and only produce some upper triangular matrix - better support for getting the trafo by appending the identity
|
there is some conflict |
thofma
reviewed
Feb 23, 2025
|
The failure in the 1.10-windows job is inside the sparse HNF code, and thus seems related to the changes here |
|
from the tests I would guess that some function call does not finish |
|
On Tue, Feb 25, 2025 at 06:39:55AM -0800, Tommy Hofmann wrote:
thofma left a comment (thofma/Hecke.jl#1766)
from the tests I would guess that some function call does not finish
Indeed - I'm looking at it now. For me it was s.w. in genera of quad
forms...
…
--
Reply to this email directly or view it on GitHub:
#1766 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
|
they are all computing class groups I believe, so it might be related? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1766 +/- ##
===========================================
+ Coverage 6.44% 76.45% +70.00%
===========================================
Files 362 362
Lines 114242 114766 +524
===========================================
+ Hits 7362 87743 +80381
+ Misses 106880 27023 -79857
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.