Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to work for flake8==5.0.0 #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DominicOram
Copy link

Fixes #87

To test:

  • Update dependencies
  • Run unit tests on master and confirm they fail
  • Run unit tests on this branch and confirm they pass

gentooboontoo added a commit to Kozea/gibolt that referenced this pull request Aug 9, 2022
Block `flake8` version due to incompatibility with `pytest-flake8`.

See:

* tholo/pytest-flake8#87
* tholo/pytest-flake8#88
evgeni added a commit to Apipie/apypie that referenced this pull request Aug 29, 2022
evgeni added a commit to Apipie/apypie that referenced this pull request Aug 29, 2022
@jaraco
Copy link

jaraco commented Oct 3, 2022

@tholo I'd love to help shepherd this change through. Any more thoughts on making me a co-owner/maintainer (#37 (comment))?

@kloczek
Copy link

kloczek commented Dec 8, 2022

Tested this PR and lookds like it is OK.
pytest is OK as well

+ /usr/bin/pytest -ra
=========================================================================== test session starts ============================================================================
platform linux -- Python 3.8.16, pytest-7.2.0, pluggy-1.0.0
rootdir: /home/tkloczko/rpmbuild/BUILD/pytest-flake8-1.1.1, configfile: tox.ini
plugins: flake8-1.1.1
collected 16 items

pytest_flake8.py .                                                                                                                                                   [  6%]
setup.py .                                                                                                                                                           [ 12%]
test_flake8.py ............x.                                                                                                                                        [100%]

========================================================================= short test summary info ==========================================================================
XFAIL test_flake8.py::test_strict - flake8 is not properly registered as a marker
====================================================================== 15 passed, 1 xfailed in 1.38s =======================================================================

lpsinger added a commit to lpsinger/pygcn that referenced this pull request Apr 5, 2023
lpsinger added a commit to nasa-gcn/pygcn that referenced this pull request Apr 5, 2023
@jaraco
Copy link

jaraco commented Jul 19, 2024

Please consider contributing this fix or others to the revived project at coherent-oss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake8 5 breaks plugin no attribute ConfigFileFinder
3 participants