Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get cache from disk to avoid cache overwriting. #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iurisilvio
Copy link

@iurisilvio iurisilvio commented Feb 4, 2023

Fix #94.

The cache is always written to the same file, for each worker and for the controller.

Controller don't execute tests and never has cache. Each worker has part of the cache, so they must get current cache to update it instead of just write to it.

It's still possible to some overwrite happen because workers don´t have a global lock. The pytest-xdist suggests to use filelock to solve this problem, but it is an external dependency.

@jaraco
Copy link

jaraco commented Jul 19, 2024

Please consider contributing this fix or others to the revived project at coherent-oss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work with pytest-xdist
2 participants