add auto cleanup helper for nl_object and use it #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a helper for automatically cleaning up a nl_object reference. Signed-off-by: Jonas Gorski <[email protected]>
Use the new _nl_auto_nl_object helper for cache where appropriate. Make sure to initialze *old to NULL in cache_include() as we do not initialize it in the error path for unknown actions. Signed-off-by: Jonas Gorski <[email protected]>
Analogue to the change for cache_include(), use the new helper for nl_objects and initialize old to NULL since we do not use it for other messages than XFRM_MSG_EXPIRE. Signed-off-by: Jonas Gorski <[email protected]>
KanjiMonster
commented
Aug 30, 2024
thom311
added a commit
that referenced
this pull request
Sep 12, 2024
|
merged as d48da13. Thank you for the patch. IMO this again shows just how useful the cleanup attribute is. While in theory everybody can reason about the proper places where to call free/unref/put, in practice it is a very error prone effort. Instead, we should be explicit about ownership transfer with the trifecta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a auto cleanup helper for
nl_object, and use it where appropriate for cache and xfrm.