Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add as_json parameter to convert directly to json #10

Merged
merged 9 commits into from
Dec 26, 2021

Conversation

thomasborgen
Copy link
Owner

@thomasborgen thomasborgen commented Dec 18, 2021

closes: #11

until dry-python/classes#330 is fixed, then we will add some type ignores :)

@thomasborgen thomasborgen changed the title Feature/add as_json parameter to convert Feature/add as_json parameter to convert directly to json Dec 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2021

Codecov Report

Merging #10 (0568823) into main (80810ef) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         2    +1     
  Lines           49        64   +15     
  Branches         5         6    +1     
=========================================
+ Hits            49        64   +15     
Impacted Files Coverage Δ
soup2dict/__init__.py 100.00% <100.00%> (ø)
soup2dict/transformer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80810ef...0568823. Read the comment docs.

@thomasborgen thomasborgen merged commit 6cf30fb into main Dec 26, 2021
@thomasborgen thomasborgen deleted the feature/add-as-json-parameter branch December 26, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add as_json parameter to convert
2 participants