Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Allow slider inversion via yaml config #134

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bjornsnoen
Copy link

@bjornsnoen bjornsnoen commented Jun 6, 2020

Useful at least for tradfri covers. They report 0% when fully extended
and 100% when fully withdrawn. Makes sense from a closed/open perspective,
but not so much when represented as a slider.

Useful at least for trafri covers. They report 0% when fully extended
and 100% when fully withdrawn. Makes sense from a closed/open perspective,
but not so much when represented as a slider.
@keteflips
Copy link

Please add this to the base branch.

@thomasloven
Copy link
Owner

See #75 and #64.

@thomasloven thomasloven reopened this Jun 20, 2020
@thomasloven
Copy link
Owner

If implemented, I think it would be neater to have it happen if step: is set to a negative value.

@bjornsnoen
Copy link
Author

If implemented, I think it would be neater to have it happen if step: is set to a negative value.

I would disagree, that would introduce secondary functionality to the step function and would potentially affect other parts of the sytem, rather than being just a change in the presentation layer.

@thomasloven
Copy link
Owner

Yes. You are right.
I'm still considering this. The close before was accidental.

@MADS0LADEN
Copy link

Any news on this? :)

@dagope
Copy link

dagope commented Jan 23, 2022

why is this solution not accepted?
if conflicts are resolved this feature is very useful.

@feutl
Copy link

feutl commented Mar 30, 2022

Would also like to see this implemented. The Somfy Covers reported via HomeKit are open with 100% and closed with 0%. The idea of creating my own cover template is nice, but for 20 covers this would be an enormous effort. Especially if the original somfy app is showing the percentages inverted already ;)

Thanks

@bjornsnoen
Copy link
Author

Had to bump rollup-plugin-typescript2 to ^0.31.0 to build with node 17 locally, didn't commit it as it's not relevant to the PR but probably had an impact on the build artifact?

@olympia
Copy link

olympia commented Sep 17, 2022

Hi @thomasloven,

First of all, thank you very much for this great card!

Re he inverted feature: are you still reluctant adding this?
The PR raised by @bjornsnoen works perfectly and superhandy opposed to the cover template solution you proposing.

@bjornsnoen many thanks for your efforts and solution. This is a key feature for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants