Skip to content

Commit

Permalink
adding pro/con solution 2
Browse files Browse the repository at this point in the history
Signed-off-by: Thomas Poignant <[email protected]>
  • Loading branch information
thomaspoignant committed Nov 27, 2024
1 parent 068a9a5 commit 253f790
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions website/src/pages/specification/20241027-flagsets.md
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ authorizedKeys:
- It is easy to give ownership of a flag set to a team, by giving them access to the file.
**CON**
- The flag set configuration is at the same place as the flag configuration, so it is possible to edit the flag set name directly inside the file _(risk of overriding another flag set)_.
- If we want the same flag to be part of multiple flag sets, we need to duplicate the flag in multiple files.
### Solution 2: specify the flag set in the retriever configuration
Expand Down Expand Up @@ -190,6 +191,16 @@ authorizedKeys:
admin:
- apikey3
```

**PRO**
- It is simple to configure a flag set by putting all the flags at the same place.
- It is easy to understand which flags are part of a flag set.
- It is easy to give ownership of a flag set to a team, by giving them access to the file.
- The flag set name is directly associated to the retriever, so it is not possible to edit it directly inside the file.

**CON**
- If we want the same flag to be part of multiple flag sets, we need to duplicate the flag in multiple files.

### Solution 3
:::note
Feel free to propose other solutions here.
Expand Down

0 comments on commit 253f790

Please sign in to comment.