Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support JSON logic rules #2863

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: Support JSON logic rules #2863

wants to merge 4 commits into from

Conversation

thomaspoignant
Copy link
Owner

Description

This PR adds support of JSONLogic type of rules in your configuration.

Closes issue(s)

Resolve #

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Signed-off-by: Thomas Poignant <[email protected]>
Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit a9fa4eb
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/676b1ee144e2bf0008d1d4b3

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 54.16667% with 22 lines in your changes missing coverage. Please review.

Project coverage is 84.47%. Comparing base (7d94c06) to head (a9fa4eb).

Files with missing lines Patch % Lines
internal/flag/rule.go 43.58% 21 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2863      +/-   ##
==========================================
- Coverage   84.79%   84.47%   -0.32%     
==========================================
  Files         111      113       +2     
  Lines        5195     5237      +42     
==========================================
+ Hits         4405     4424      +19     
- Misses        625      647      +22     
- Partials      165      166       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant