Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support JSON logic rules #2863

Merged
merged 11 commits into from
Jan 9, 2025
Merged

feat: Support JSON logic rules #2863

merged 11 commits into from
Jan 9, 2025

Conversation

thomaspoignant
Copy link
Owner

@thomaspoignant thomaspoignant commented Dec 24, 2024

Description

This PR adds support of JSONLogic type of rules in your configuration.

Closes issue(s)

Resolve #

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Signed-off-by: Thomas Poignant <[email protected]>
Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for go-feature-flag-doc-preview ready!

Name Link
🔨 Latest commit c155ef6
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/677ff178eb92e300084d2cbe
😎 Deploy Preview https://deploy-preview-2863--go-feature-flag-doc-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 79.16667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 84.72%. Comparing base (b05f4ef) to head (c155ef6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/flag/rule.go 74.35% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2863      +/-   ##
==========================================
- Coverage   84.79%   84.72%   -0.07%     
==========================================
  Files         111      113       +2     
  Lines        5195     5237      +42     
==========================================
+ Hits         4405     4437      +32     
- Misses        625      634       +9     
- Partials      165      166       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomaspoignant thomaspoignant marked this pull request as ready for review January 8, 2025 20:03
@thomaspoignant thomaspoignant removed the WIP label Jan 8, 2025
Copy link

sonarqubecloud bot commented Jan 9, 2025

@thomaspoignant thomaspoignant merged commit 544b033 into main Jan 9, 2025
21 checks passed
@thomaspoignant thomaspoignant deleted the jsonlogic-rules branch January 9, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant