-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add elixir-provider #2610
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2610 +/- ##
==========================================
- Coverage 84.87% 84.83% -0.05%
==========================================
Files 111 111
Lines 5178 5184 +6
==========================================
+ Hits 4395 4398 +3
- Misses 620 623 +3
Partials 163 163 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JoE11-y thanks a lot for this pull request, I am super excited to have support for Elixir 😄.
I haven't looked enough yet to be able to provide feedback, but I was wondering if you plan to add any tests for this PR?
Forget about it, I should have read the PR description.
I am really looking forward to complete this PR 🙌 .
Thank you @thomaspoignant. Will complete this by today's end 💪 |
Hey @JoE11-y do you still want to add the tests or should I look at it myself? |
Apologies for the delay, got sidetracked. |
Quality Gate passedIssues Measures |
Description
Work to do:
Pr adding elixir provider to the go-feature-flag
Closes issue(s)
Resolve #
Checklist
README.md
and/website/docs
)