-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(example): Fixing link in react example #2756
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b790403
docs(example): Fixing link in react example
thomaspoignant cdb2da8
Merge branch 'main' into issue-2755
thomaspoignant 994e0d0
Refactor example
thomaspoignant 91d5467
refactor app
thomaspoignant 55559df
Merge branch 'main' into issue-2755
thomaspoignant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
import "./App.css"; | ||
import { EvaluationContext, OpenFeature, OpenFeatureProvider, useFlag } from "@openfeature/react-sdk"; | ||
import { GoFeatureFlagWebProvider } from "@openfeature/go-feature-flag-web-provider"; | ||
import {EvaluationContext, OpenFeature, OpenFeatureProvider, useFlag} from "@openfeature/react-sdk"; | ||
import {GoFeatureFlagWebProvider} from "@openfeature/go-feature-flag-web-provider"; | ||
|
||
const goFeatureFlagWebProvider = new GoFeatureFlagWebProvider({ | ||
endpoint: "http://localhost:1031" | ||
|
@@ -15,35 +15,35 @@ OpenFeature.setProvider(goFeatureFlagWebProvider); | |
function App() { | ||
return ( | ||
<OpenFeatureProvider> | ||
<Page /> | ||
<Page/> | ||
</OpenFeatureProvider> | ||
); | ||
} | ||
|
||
function Page() { | ||
const { value: hideLogo } = useFlag("hide-logo", false); | ||
const { value: titleFlag } = useFlag("title-flag", "GO Feature Flag"); | ||
const { value: badgeClass } = useFlag("badge-class", ""); | ||
const {value: hideLogo} = useFlag("hide-logo", false); | ||
const {value: titleFlag} = useFlag("title-flag", "GO Feature Flag"); | ||
const {value: badgeClass} = useFlag("badge-class", ""); | ||
|
||
const setRandomEvaluationContext = () => { | ||
const availableContexts: Array<EvaluationContext> = [ | ||
{ targetingKey: "user-2", userType: "dev", email: "[email protected]" }, | ||
{ targetingKey: "user-3", userType: "admin", company: "GO Feature Flag" }, | ||
{ targetingKey: "user-4", userType: "customer", location: "Paris" }, | ||
{ targetingKey: "user-5" } | ||
{targetingKey: "user-2", userType: "dev", email: "[email protected]"}, | ||
{targetingKey: "user-3", userType: "admin", company: "GO Feature Flag"}, | ||
{targetingKey: "user-4", userType: "customer", location: "Paris"}, | ||
{targetingKey: "user-5"} | ||
|
||
]; | ||
const randomIndex = Math.floor(Math.random() * availableContexts.length); | ||
OpenFeature.setContext(availableContexts[randomIndex]); | ||
}; | ||
|
||
const userType =OpenFeature.getContext().userType ?? "anonymous" as string; | ||
const userType = OpenFeature.getContext().userType ?? "anonymous" as string; | ||
|
||
return ( | ||
<> | ||
<div> | ||
<a href="https://gofeatureflag.org" target="_blank"> | ||
{!hideLogo && <img src="/public/logo.png" className="logo" alt="GO Feature Flag logo" />} | ||
{!hideLogo && <img src="/public/logo.png" className="logo" alt="GO Feature Flag logo"/>} | ||
</a> | ||
</div> | ||
<h2>React example app</h2> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit unrealistic example. You would never load more than one context. At least I can't think of a use case.
I would really like to split App and Page, so init and usage would be clearly distinguished. I get the idea of "lets show everything in one place", but I would say it's a bit hard to understand what is what.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I got it, I will rework the example to make it more explicit.