Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uploads in dynamic folder mode #18

Open
wants to merge 4 commits into
base: v1
Choose a base branch
from

Conversation

jorisnoo
Copy link

@jorisnoo jorisnoo commented Nov 9, 2024

Another issue i ran into seems to be related to dynamic folder mode. In my case, this is enabled, and it seems to be the new default and only option for new Cloudinary accounts. I noticed, however, that you apparently dropped support for it in the second Version of this plugin? As soon as I'll be upgrading to Craft 5 this would likely become an issue, so i'd love to hear your thoughts on this. Since i now rely on this plugin i'd obviously be happy to help :)

As for now, i noticed that at least the upload and the rename webhooks do not work with dynamic folder mode, presumably because the parameter for the folder is called asset_folder instead of folder?

I have no way now to verify this with an account that is in 'fixed' folder mode, but this seems to do the trick for me.

Thanks!

@thomasvantuycom
Copy link
Owner

Hello Joris,

Thank you for your contributions to this plugin! I did decide to drop support for dynamic folders, unaware that Cloudinary would soon make it the default for all new accounts, both free and paid. Recently, I’ve been giving dynamic folders another try to see if I can make them work smoothly with Craft’s file organization system. I've managed to resolve most issues, but one challenge remains—related to a delay in propagation on the Cloudinary CDN when moving folders with assets inside. I’m not yet sure if I can fully overcome this, but I’m considering releasing an updated version with support for dynamic folders mode.

I’ll need a few more days to assess what’s feasible. After that, I’ll work on incorporating your additions and fixes into either the current or a new version of the plugin.

@jorisnoo
Copy link
Author

Hi Thomas,

Thanks for your response. Please let me know once you've decided on how you'd like to proceed or in case you'd like my support with anything related to this. I've just started out debugging the issues i encountered, but think i slowly start to get a better understanding of the plugin and the flysystem integration. So i'd be happy to coordinate any further effort.

In case you decide to go with a new version, i may consider backporting the updates to the Version running with Craft 4. I think a major difference to v5 are the shared filesystems using different subpaths?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants