Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add metadata to advise results #2375

Closed

Conversation

mayaCostantini
Copy link
Contributor

Related Issues and Dependencies

Related to #2180

  • make sure adviser provides tags/categories in metadata

This introduces a breaking change

  • Yes

Needs User API schema revision.

This should yield a new module release

  • Yes

This Pull Request implements

Keep advise metadata in report (number of packages added / removed, number of justifications, advise id, stack_info count).
This Pull Request is a WIP and needs further testing.

If any metadata that it would be interesting to have is missing, please add it in a comment.

@sesheta sesheta added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 5, 2022
@sesheta
Copy link
Member

sesheta commented Aug 5, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from mayacostantini after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta requested review from codificat and harshad16 August 5, 2022 12:54
@sesheta
Copy link
Member

sesheta commented Aug 5, 2022

@mayaCostantini: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/pytest fd5beef link true /test thoth-pytest-py38
aicoe-ci/prow/pre-commit fd5beef link true /test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mayaCostantini
Copy link
Contributor Author

Closing this PR due to change of approach in the clustering of advise results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants